Skip to content

Swift: Added example code for text to image generation with Amazon Nova Canvas for Bedrock #7452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

monadierickx
Copy link
Contributor

This pull request includes one code example for image generation with Nova Canvas.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the Swift This issue relates to the AWS SDK for Swift label May 19, 2025
@sebsto
Copy link

sebsto commented May 19, 2025

I think you need to remove the Llama code from this PR. Start from the main branch. Otherwise looks good, I left a few comments at code level.

Copy link

@sebsto sebsto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions and questions

@DennisTraub DennisTraub self-requested a review May 20, 2025 07:19
@@ -423,6 +423,14 @@ bedrock-runtime_Converse_MetaLlama:
- description: Send a text message to Meta Llama, using Bedrock's Converse API.
snippet_tags:
- javascript.v3.bedrock-runtime.Converse_MetaLlama
Swift:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change appears to be carried over from PR #7434. Could you please remove it to keep PRs isolated? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do this!

@@ -708,6 +716,14 @@ bedrock-runtime_ConverseStream_MetaLlama:
- description: Send a text message to Meta Llama, using Bedrock's Converse API and process the response stream in real-time.
snippet_tags:
- javascript.v3.bedrock-runtime.ConverseStream_MetaLlama
Swift:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, please remove.

Copy link
Contributor

@DennisTraub DennisTraub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several changes in this PR appear to be carried over from PR #7434. Please remove these unrelated modifications to maintain isolated PRs. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carried over from #7434. Please remove.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carried over from #7434. Please remove.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carried over from #7434. Please remove.

@monadierickx monadierickx requested a review from DennisTraub May 22, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Swift This issue relates to the AWS SDK for Swift
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants